antscloud / fretboardgtr

Python package for creating fretboard and chord diagram image in svg format
GNU Affero General Public License v3.0
112 stars 17 forks source link

Display both note names and scale degrees #24

Open MarkMayhew opened 11 months ago

MarkMayhew commented 11 months ago

Is your feature request related to a problem? Please describe. It is not possible to set both "show_degree_name" and "show_note_name" as True and get the output to have both.

Describe the solution you'd like Both scale degrees and note names shown. Might be better in a square/rectangle rather than a circle.

Describe alternatives you've considered Digging into the code myself

Additional context n/a

antscloud commented 11 months ago

Hi, thank you for the issue

At the moment, show_degree_nameand show_note_name are indeed exclusive. I never though of displaying both at the same time. It might be feasible though but i'm really not sure of the rendering because it can overlap based on the fontsize, and this can be quite tricky to make a constraint