search

anttikon / routahe

MIT License
37 stars 8 forks source link

Pedantic suggestions #3

Closed dronir closed 7 years ago

dronir commented 7 years ago

Hi, a bit of pedantry here that you can disregard if you want to.

The current output color scheme is a bit incongruous. HSL has official colors for the different transport modes (https://www.hsl.fi/tyyliopas/varit): blue for buses, green for tram, orange for metro, purple for train, and lightblue for ferry (walking isn't mentioned, but seems to be just grey in Reittiopas).

Second, the Helsinki metro is called "metro" in English, not "subway".

anttikon commented 7 years ago

Hi!

Your suggestion about the color scheme seems reasonable. Unfortunately ANSI contains only eight standard colors.

However I changed the color scheme a bit as you can see in 9bdde59df3defb6a0ab6f1cc745e60ba46ffb932. I think that the new color scheme is as close to official color scheme as possible. For an example tram does really feel green.

And metro is metro indeed! In fact Routahe gets the term "subway" straight from the HSL API, so for now I wouldn't change it but I'll definitely consider the issue!

🚌💨