get_companies() regex cuts out several companies when directly copying and pasting from the Component List

anttsou / qmj

8 stars 8 forks source link

get_companies() regex cuts out several companies when directly copying and pasting from the Component List #17

Closed rynkwn closed 8 years ago

rynkwn commented 8 years ago

Specifically, when this issue pops up: TRIPADVISOR INC TRIPAs of 06/26/2015 Russell Indexes.

We're parsing for lines that are entirely capitalized, so TRIP isn't read in as a company. Should be easy to fix. Just get rid of the excess chunk of a line after reading in an "As of"

rynkwn commented 8 years ago

Correction. Apparently my vision is fading. Bug is a non-issue. Though running get_companies yields 5 more companies.

rynkwn commented 8 years ago

Resolved. Copy and paste of Russell 3000 Index inserts hidden newlines between a Company's ticker and the "As of" detritus, meaning that code correctly handles the input.

Additionally, resulting number of companies found matches exactly (3004) number of companies in Russell 3000 Index as of now.