antville / helma

Antville Fork of Helma Object Publisher
https://antville.org
Other
3 stars 1 forks source link

Resolve java warnings #107

Closed p3k closed 1 month ago

p3k commented 1 month ago

Resolve the following warnings:

Before:

> Task :compileJava
/helma/build/src/main/java/helma/framework/core/TypeManager.java:195: warning: [removal] Long(long) in Long has been deprecated and marked for removal
                lastRepoScan.put(repository, new Long(repository.lastModified()));
                                             ^
/helma/build/src/main/java/helma/main/Server.java:573: warning: [removal] SecurityManager in java.lang has been deprecated and marked for removal
                SecurityManager secMan = (SecurityManager) Class.forName(secManClass)
                ^
/helma/build/src/main/java/helma/main/Server.java:573: warning: [removal] SecurityManager in java.lang has been deprecated and marked for removal
                SecurityManager secMan = (SecurityManager) Class.forName(secManClass)
                                          ^
/helma/build/src/main/java/helma/main/Server.java:576: warning: [removal] setSecurityManager(SecurityManager) in System has been deprecated and marked for removal
                System.setSecurityManager(secMan);
                      ^
/helma/build/src/main/java/helma/objectmodel/db/Transactor.java:243: warning: [removal] Long(long) in Long has been deprecated and marked for removal
        testedConnections.put(src, new Long(System.currentTimeMillis()));
                                   ^
/helma/build/src/main/java/helma/objectmodel/db/Transactor.java:265: warning: [removal] Long(long) in Long has been deprecated and marked for removal
                testedConnections.put(src, new Long(now));
                                           ^
/helma/build/src/main/java/helma/objectmodel/db/Transactor.java:522: warning: [removal] stop() in Thread has been deprecated and marked for removal
                    thread.stop();
                          ^
/helma/build/src/main/java/helma/objectmodel/db/Property.java:96: warning: [removal] Long(long) in Long has been deprecated and marked for removal
                    value = new Long(in.readLong());
                            ^
/helma/build/src/main/java/helma/objectmodel/db/Property.java:106: warning: [removal] Double(double) in Double has been deprecated and marked for removal
                    value = new Double(in.readDouble());
                            ^
/helma/build/src/main/java/helma/objectmodel/db/Property.java:234: warning: [removal] Long(long) in Long has been deprecated and marked for removal
        value = new Long(l);
                ^
/helma/build/src/main/java/helma/objectmodel/db/Property.java:245: warning: [removal] Double(double) in Double has been deprecated and marked for removal
        value = new Double(d);
                ^
/helma/build/src/main/java/helma/scripting/rhino/RhinoCore.java:572: warning: [removal] Long(long) in Long has been deprecated and marked for removal
            Object[] args = { new Long(d.getTime()) };
                              ^
/helma/build/src/main/java/helma/scripting/rhino/RhinoCore.java:621: warning: [removal] Double(double) in Double has been deprecated and marked for removal
                return new Double(n.doubleValue());
                       ^
/helma/build/src/main/java/helma/scripting/rhino/RhinoCore.java:623: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
                return new Integer(n.intValue());
                       ^
/helma/build/src/main/java/helma/scripting/rhino/RhinoCore.java:1149: warning: [removal] Long(long) in Long has been deprecated and marked for removal
                Object[] args = { new Long(((Date) obj).getTime()) };
                                  ^
/helma/build/src/main/java/helma/scripting/rhino/PathWrapper.java:109: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
            ids[i] = new Integer(i);
                     ^
/helma/build/src/main/java/helma/scripting/rhino/extensions/DatabaseObject.java:518: warning: [removal] Long(long) in Long has been deprecated and marked for removal
                        return new Long(resultSet.getLong(index));
                               ^
/helma/build/src/main/java/helma/scripting/rhino/extensions/DatabaseObject.java:523: warning: [removal] Double(double) in Double has been deprecated and marked for removal
                        return new Double(resultSet.getDouble(index));
                               ^
/helma/build/src/main/java/helma/scripting/rhino/extensions/DatabaseObject.java:533: warning: [removal] Double(double) in Double has been deprecated and marked for removal
                            return new Double(num.doubleValue());
                                   ^
/helma/build/src/main/java/helma/scripting/rhino/extensions/DatabaseObject.java:535: warning: [removal] Long(long) in Long has been deprecated and marked for removal
                            return new Long(num.longValue());
                                   ^
/helma/build/src/main/java/helma/scripting/rhino/HopObject.java:882: warning: [removal] Long(long) in Long has been deprecated and marked for removal
                        Object[] args = { new Long(d.getTime()) };
                                          ^
/helma/build/src/main/java/helma/scripting/rhino/JSAdapter.java:103: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
            return call(func, new Object[] { new Integer(index) });
                                             ^
/helma/build/src/main/java/helma/scripting/rhino/JSAdapter.java:124: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
            Object res = call(func, new Object[] { new Integer(index) });
                                                   ^
/helma/build/src/main/java/helma/scripting/rhino/JSAdapter.java:150: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
                call(func, new Object[] { new Integer(index), value });
                                          ^
/helma/build/src/main/java/helma/scripting/rhino/JSAdapter.java:172: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
            call(func, new Object[] { new Integer(index) });
                                      ^
/helma/build/src/main/java/helma/scripting/rhino/JSAdapter.java:299: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
            return new Integer(((Double)tmp).intValue());
                   ^
/helma/build/src/main/java/helma/scripting/rhino/debug/Profiler.java:109: warning: [removal] Long(long) in Long has been deprecated and marked for removal
            timer.push(new Long(time));
                       ^
/helma/build/src/main/java/helma/util/CronJob.java:453: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    Integer theYear = new Integer(cal.get(Calendar.YEAR));
                      ^
/helma/build/src/main/java/helma/util/CronJob.java:457: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    Integer theMonth = new Integer(cal.get(Calendar.MONTH));
                       ^
/helma/build/src/main/java/helma/util/CronJob.java:461: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    Integer theDay = new Integer(cal.get(Calendar.DAY_OF_MONTH));
                     ^
/helma/build/src/main/java/helma/util/CronJob.java:465: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    Integer theWeekDay = new Integer(cal.get(Calendar.DAY_OF_WEEK));
                         ^
/helma/build/src/main/java/helma/util/CronJob.java:469: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    Integer theHour = new Integer(cal.get(Calendar.HOUR_OF_DAY));
                      ^
/helma/build/src/main/java/helma/util/CronJob.java:473: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    Integer theMinute = new Integer(cal.get(Calendar.MINUTE));
                        ^
/helma/build/src/main/java/helma/util/CronJob.java:487: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.year.add(new Integer(year));
                  ^
/helma/build/src/main/java/helma/util/CronJob.java:495: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.year.remove(new Integer(year));
                     ^
/helma/build/src/main/java/helma/util/CronJob.java:523: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.month.add(new Integer(month));
                   ^
/helma/build/src/main/java/helma/util/CronJob.java:533: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.month.remove(new Integer(month));
                      ^
/helma/build/src/main/java/helma/util/CronJob.java:559: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.day.add(new Integer(day));
                 ^
/helma/build/src/main/java/helma/util/CronJob.java:567: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.day.remove(new Integer(day));
                    ^
/helma/build/src/main/java/helma/util/CronJob.java:595: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.weekday.add(new Integer(weekday));
                     ^
/helma/build/src/main/java/helma/util/CronJob.java:605: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.weekday.remove(new Integer(weekday));
                        ^
/helma/build/src/main/java/helma/util/CronJob.java:631: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.hour.add(new Integer(hour));
                  ^
/helma/build/src/main/java/helma/util/CronJob.java:639: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.hour.remove(new Integer(hour));
                     ^
/helma/build/src/main/java/helma/util/CronJob.java:665: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.minute.add(new Integer(minute));
                    ^
/helma/build/src/main/java/helma/util/CronJob.java:673: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
    this.minute.remove(new Integer(minute));
                       ^
/helma/build/src/main/java/helma/objectmodel/TransientProperty.java:79: warning: [removal] Boolean(boolean) in Boolean has been deprecated and marked for removal
                return new Boolean(bvalue);
                       ^
/helma/build/src/main/java/helma/objectmodel/TransientProperty.java:82: warning: [removal] Long(long) in Long has been deprecated and marked for removal
                return new Long(lvalue);
                       ^
/helma/build/src/main/java/helma/objectmodel/TransientProperty.java:85: warning: [removal] Double(double) in Double has been deprecated and marked for removal
                return new Double(dvalue);
                       ^
/helma/build/src/main/java/helma/objectmodel/dom/XmlDatabaseReader.java:228: warning: [removal] Double(String) in Double has been deprecated and marked for removal
                prop.setFloatValue((new Double(charValue)).doubleValue());
                                    ^
/helma/build/src/main/java/helma/objectmodel/dom/XmlDatabaseReader.java:230: warning: [removal] Long(String) in Long has been deprecated and marked for removal
                prop.setIntegerValue((new Long(charValue)).longValue());
                                      ^
/helma/build/src/main/java/helma/objectmodel/dom/XmlReader.java:302: warning: [removal] Double(String) in Double has been deprecated and marked for removal
                currentNode.setFloat(elementName, (new Double(charValue)).doubleValue());
                                                   ^
/helma/build/src/main/java/helma/objectmodel/dom/XmlReader.java:304: warning: [removal] Long(String) in Long has been deprecated and marked for removal
                currentNode.setInteger(elementName, (new Long(charValue)).longValue());
                                                     ^
/helma/build/src/main/java/helma/main/HelmaSecurityManager.java:33: warning: [removal] SecurityManager in java.lang has been deprecated and marked for removal
public class HelmaSecurityManager extends SecurityManager {
                                          ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
53 warnings

After:

> Task :compileJava
/helma/build/src/main/java/helma/main/Server.java:573: warning: [removal] SecurityManager in java.lang has been deprecated and marked for removal
                SecurityManager secMan = (SecurityManager) Class.forName(secManClass)
                ^
/helma/build/src/main/java/helma/main/Server.java:573: warning: [removal] SecurityManager in java.lang has been deprecated and marked for removal
                SecurityManager secMan = (SecurityManager) Class.forName(secManClass)
                                          ^
/helma/build/src/main/java/helma/main/Server.java:576: warning: [removal] setSecurityManager(SecurityManager) in System has been deprecated and marked for removal
                System.setSecurityManager(secMan);
                      ^
/helma/build/src/main/java/helma/objectmodel/db/Transactor.java:522: warning: [removal] stop() in Thread has been deprecated and marked for removal
                    thread.stop();
                          ^
/helma/build/src/main/java/helma/main/HelmaSecurityManager.java:33: warning: [removal] SecurityManager in java.lang has been deprecated and marked for removal
public class HelmaSecurityManager extends SecurityManager {
                                          ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
5 warnings
p3k commented 1 month ago

It looks like solving the warnings related to the SecurityManager need more comprehensive code changes. Thus, I am going to resolve the easy ones swiftly, and create an extra issue for the SecurityManager.