antvis / Graphin

A React toolkit for graph visualization based on G6
https://graphin.antv.antgroup.com
MIT License
980 stars 263 forks source link

Misspelled type name in source code #482

Open maxott opened 1 year ago

maxott commented 1 year ago

Describe the bug

Apparent typo in source code

https://github.com/antvis/Graphin/blob/master/packages/graphin/src/behaviors/ZoomCanvas.tsx
export type IDragCanvasProps = Partial<typeof defaultConfig>;

should most likely be:

export type IZoomCanvasProps = Partial<typeof defaultConfig>;

Your Example Website or App

none - just starting

Steps to Reproduce the Bug or Issue

See above

Expected behavior

See above.

In fact, I'm not sure if those types are directly exposed. Right now I access them directly:

import { IDragCanvasProps as IZoomCanasProps } from '@antv/graphin/lib/behaviors/ZoomCanvas'

Screenshots or Videos

No response

Platform

Any - just source code issue

Additional context

No response

pomelo-nwu commented 11 months ago

@maxott Yes, your finding is right. Could you give me a PR to fix it? Thank you very much