fix: 修复在明细表中绘制 G2 图表, 点击单元格报错 close #2843

antvis / S2

⚡️ A practical visualization library for tabular analysis.

https://s2.antv.antgroup.com

MIT License

1.48k stars 194 forks source link

fix: 修复在明细表中绘制 G2 图表, 点击单元格报错 close #2843 #2864

Closed lijinke666 closed 2 months ago

lijinke666 commented 2 months ago

👀 PR includes

🐛 Bugfix

[x] Solve the issue and close #2843

📝 Description

明细表普通单元格点击 tooltip 展示的是自身的数值, 对于自身是图表的场景不应该渲染 tooltip, 这里是错误的把图表数据渲染在 Tooltip 的 JSX 中, 所以报错了

🖼️ Screenshot

Before	After
❌	✅

🔗 Related issue link

🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
antvis-s2	❌ Failed (Inspect)			Aug 16, 2024 6:05am

github-actions[bot] commented 2 months ago

Size Change: +8 B (0%)

Total Size: 329 kB

Filename	Size	Change
`./packages/s2-core/dist/index.min.js`	229 kB	+8 B (0%)

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `./packages/s2-core/dist/style.min.css` | 388 B | | `./packages/s2-react/dist/index.min.js` | 70.8 kB | | `./packages/s2-react/dist/style.min.css` | 3.88 kB | | `./packages/s2-vue/dist/index.min.js` | 22.9 kB | | `./packages/s2-vue/dist/style.min.css` | 1.97 kB |

_{compressed-size-action}

github-actions[bot] commented 2 months ago

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.79%. Comparing base (ecdc9c8) to head (0a6fe65). Report is 423 commits behind head on next.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## next #2864 +/- ## ========================================== + Coverage 75.77% 80.79% +5.02% ========================================== Files 257 180 -77 Lines 11994 10401 -1593 Branches 2464 2359 -105 ========================================== - Hits 9088 8404 -684 + Misses 1398 554 -844 + Partials 1508 1443 -65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lijinke666 commented 2 months ago

:tada: This PR is included in version @antv/s2-v2.0.0-next.27 :tada:

The release is available on:

Your semantic-release bot :package::rocket: