antvis / S2

⚡️ A practical visualization library for tabular analysis.
https://s2.antv.antgroup.com
MIT License
1.49k stars 196 forks source link

fix: 修复父容器存在 transform 时, 在 canvas 内点击也会重置交互的问题 close #2879 #2942

Closed lijinke666 closed 1 month ago

lijinke666 commented 1 month ago

👀 PR includes

🐛 Bugfix

📝 Description

背景见 #2879

const s2Options = {
  supportCSSTransform: true
}

🖼️ Screenshot

Before After
Kapture 2024-10-25 at 11 31 24 Kapture 2024-10-25 at 11 34 23

🔗 Related issue link

🔍 Self-Check before the merge

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Oct 25, 2024 3:42am
github-actions[bot] commented 1 month ago

Size Change: +104 B (0%)

Total Size: 7.97 MB

Filename Size Change
./packages/s2-core/dist/index.min.js 183 kB +26 B (+0.01%)
./packages/s2-react/node_modules/@antv/s2/dist/index.min.js 183 kB +26 B (+0.01%)
./packages/s2-shared/node_modules/@antv/s2/dist/index.min.js 183 kB +26 B (+0.01%)
./packages/s2-vue/node_modules/@antv/s2/dist/index.min.js 183 kB +26 B (+0.01%)
ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `./packages/s2-core/dist/style.min.css` | 391 B | | `./packages/s2-core/node_modules/@antv/g-canvas/dist/g.min.js` | 61.7 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js` | 22.1 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js` | 21.5 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js` | 86.8 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js` | 48.8 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/config.js` | 1.14 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js` | 1.86 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js` | 1.19 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/events.js` | 1.53 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js` | 299 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js` | 742 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js` | 805 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js` | 1.09 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/index.js` | 1.14 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js` | 1.05 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js` | 1.12 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js` | 1.72 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js` | 339 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js` | 571 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js` | 710 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js` | 418 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js` | 1.78 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js` | 489 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js` | 2.64 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js` | 496 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js` | 1.01 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js` | 719 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js` | 1.8 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js` | 2.82 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js` | 1.63 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js` | 1.5 kB | | `./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js` | 736 B | | `./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js` | 2.34 kB | | `./packages/s2-core/node_modules/d3-dsv/dist/d3-dsv.js` | 2.31 kB | | `./packages/s2-core/node_modules/d3-dsv/dist/d3-dsv.min.js` | 1.53 kB | | `./packages/s2-core/node_modules/d3-interpolate/dist/d3-interpolate.js` | 4.55 kB | | `./packages/s2-core/node_modules/d3-interpolate/dist/d3-interpolate.min.js` | 3.19 kB | | `./packages/s2-core/node_modules/d3-timer/dist/d3-timer.js` | 1.44 kB | | `./packages/s2-core/node_modules/d3-timer/dist/d3-timer.min.js` | 924 B | | `./packages/s2-core/node_modules/tinycolor2/dist/tinycolor-min.js` | 5.5 kB | | `./packages/s2-react/dist/index.min.js` | 68.6 kB | | `./packages/s2-react/dist/style.min.css` | 3.4 kB | | `./packages/s2-react/node_modules/@ant-design/icons/dist/index.umd.js` | 200 kB | | `./packages/s2-react/node_modules/@ant-design/icons/dist/index.umd.min.js` | 170 kB | | `./packages/s2-react/node_modules/@antv/g-canvas/dist/g.min.js` | 61.7 kB | | `./packages/s2-react/node_modules/@antv/s2/dist/style.min.css` | 391 B | | `./packages/s2-react/node_modules/@testing-library/react/dist/@testing-library/react.cjs.js` | 4.26 kB | | `./packages/s2-react/node_modules/@testing-library/react/dist/@testing-library/react.esm.js` | 3.87 kB | | `./packages/s2-react/node_modules/@testing-library/react/dist/@testing-library/react.pure.cjs.js` | 3.95 kB | | `./packages/s2-react/node_modules/@testing-library/react/dist/@testing-library/react.pure.esm.js` | 3.57 kB | | `./packages/s2-react/node_modules/@testing-library/react/dist/@testing-library/react.pure.umd.js` | 74.6 kB | | `./packages/s2-react/node_modules/@testing-library/react/dist/@testing-library/react.pure.umd.min.js` | 39.1 kB | | `./packages/s2-react/node_modules/@testing-library/react/dist/@testing-library/react.umd.js` | 74.9 kB | | `./packages/s2-react/node_modules/@testing-library/react/dist/@testing-library/react.umd.min.js` | 39.2 kB | | `./packages/s2-react/node_modules/@testing-library/react/dist/act-compat.js` | 1.85 kB | | `./packages/s2-react/node_modules/@testing-library/react/dist/fire-event.js` | 855 B | | `./packages/s2-react/node_modules/@testing-library/react/dist/index.js` | 631 B | | `./packages/s2-react/node_modules/@testing-library/react/dist/pure.js` | 2.04 kB | | `./packages/s2-react/node_modules/ahooks/dist/ahooks.js` | 32.1 kB | | `./packages/s2-react/node_modules/antd/dist/antd-with-locales.js` | 768 kB | | `./packages/s2-react/node_modules/antd/dist/antd-with-locales.min.js` | 349 kB | | `./packages/s2-react/node_modules/antd/dist/antd.compact.css` | 72.4 kB | | `./packages/s2-react/node_modules/antd/dist/antd.compact.min.css` | 67.9 kB | | `./packages/s2-react/node_modules/antd/dist/antd.css` | 72.4 kB | | `./packages/s2-react/node_modules/antd/dist/antd.dark.css` | 73.7 kB | | `./packages/s2-react/node_modules/antd/dist/antd.dark.min.css` | 69.3 kB | | `./packages/s2-react/node_modules/antd/dist/antd.js` | 693 kB | | `./packages/s2-react/node_modules/antd/dist/antd.min.css` | 68 kB | | `./packages/s2-react/node_modules/antd/dist/antd.min.js` | 293 kB | | `./packages/s2-react/node_modules/antd/dist/antd.variable.css` | 77.4 kB | | `./packages/s2-react/node_modules/antd/dist/antd.variable.min.css` | 68.5 kB | | `./packages/s2-react/node_modules/antd/dist/compact-theme.js` | 121 B | | `./packages/s2-react/node_modules/antd/dist/dark-theme.js` | 119 B | | `./packages/s2-react/node_modules/antd/dist/default-theme.js` | 7.71 kB | | `./packages/s2-react/node_modules/antd/dist/theme.js` | 4.29 kB | | `./packages/s2-react/node_modules/antd/dist/variable-theme.js` | 123 B | | `./packages/s2-react/node_modules/d3-dsv/dist/d3-dsv.js` | 2.31 kB | | `./packages/s2-react/node_modules/d3-dsv/dist/d3-dsv.min.js` | 1.53 kB | | `./packages/s2-react/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.cjs.js` | 45.9 kB | | `./packages/s2-react/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.esm.js` | 45.7 kB | | `./packages/s2-react/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.js` | 73.6 kB | | `./packages/s2-react/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.min.js` | 31.3 kB | | `./packages/s2-react/node_modules/vite-plugin-svgr/dist/index.js` | 828 B | | `./packages/s2-shared/node_modules/@antv/s2/dist/style.min.css` | 391 B | | `./packages/s2-vue/dist/index.min.js` | 22.2 kB | | `./packages/s2-vue/dist/style.min.css` | 1.67 kB | | `./packages/s2-vue/node_modules/@antv/s2/dist/style.min.css` | 391 B | | `./packages/s2-vue/node_modules/@testing-library/vue/dist/fire-event.js` | 1.4 kB | | `./packages/s2-vue/node_modules/@testing-library/vue/dist/index.js` | 584 B | | `./packages/s2-vue/node_modules/@testing-library/vue/dist/render.js` | 1.57 kB | | `./packages/s2-vue/node_modules/@vue/shared/dist/shared.cjs.js` | 7.91 kB | | `./packages/s2-vue/node_modules/@vue/shared/dist/shared.cjs.prod.js` | 7.9 kB | | `./packages/s2-vue/node_modules/@vue/shared/dist/shared.esm-bundler.js` | 7.66 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd-with-locales.js` | 745 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd-with-locales.min.js` | 367 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd.compact.css` | 73 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd.compact.min.css` | 66.1 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd.css` | 73 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd.dark.css` | 74.3 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd.dark.min.css` | 67.3 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd.js` | 679 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd.min.css` | 66.1 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd.min.js` | 317 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd.variable.css` | 78.7 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/antd.variable.min.css` | 66.7 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/compact-theme.js` | 121 B | | `./packages/s2-vue/node_modules/ant-design-vue/dist/dark-theme.js` | 119 B | | `./packages/s2-vue/node_modules/ant-design-vue/dist/default-theme.js` | 7.62 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/theme.js` | 4.23 kB | | `./packages/s2-vue/node_modules/ant-design-vue/dist/variable-theme.js` | 123 B | | `./packages/s2-vue/node_modules/vue/dist/vue.cjs.js` | 1.01 kB | | `./packages/s2-vue/node_modules/vue/dist/vue.cjs.prod.js` | 820 B | | `./packages/s2-vue/node_modules/vue/dist/vue.esm-browser.js` | 106 kB | | `./packages/s2-vue/node_modules/vue/dist/vue.esm-browser.prod.js` | 51.1 kB | | `./packages/s2-vue/node_modules/vue/dist/vue.esm-bundler.js` | 913 B | | `./packages/s2-vue/node_modules/vue/dist/vue.global.js` | 106 kB | | `./packages/s2-vue/node_modules/vue/dist/vue.global.prod.js` | 49.9 kB | | `./packages/s2-vue/node_modules/vue/dist/vue.runtime.esm-browser.js` | 72.7 kB | | `./packages/s2-vue/node_modules/vue/dist/vue.runtime.esm-browser.prod.js` | 33.3 kB | | `./packages/s2-vue/node_modules/vue/dist/vue.runtime.esm-bundler.js` | 306 B | | `./packages/s2-vue/node_modules/vue/dist/vue.runtime.global.js` | 74 kB | | `./packages/s2-vue/node_modules/vue/dist/vue.runtime.global.prod.js` | 33.1 kB |

compressed-size-action

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.94%. Comparing base (1adc25d) to head (5fe1c23). Report is 182 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2942 +/- ## ========================================== + Coverage 76.48% 79.94% +3.46% ========================================== Files 240 160 -80 Lines 12312 9540 -2772 Branches 2630 2061 -569 ========================================== - Hits 9417 7627 -1790 + Misses 1377 603 -774 + Partials 1518 1310 -208 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lijinke666 commented 4 weeks ago

:tada: This PR is included in version @antv/s2-v1.56.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: