fix: 修复自定义菜单项不触发 click 事件的问题

antvis / S2

⚡️ A practical visualization library for tabular analysis.

https://s2.antv.antgroup.com

MIT License

1.49k stars 196 forks source link

fix: 修复自定义菜单项不触发 click 事件的问题 #2946

Closed lijinke666 closed 3 weeks ago

lijinke666 commented 3 weeks ago

👀 PR includes

🐛 Bugfix

[x] Solve the issue and close #0

📝 Description

在 https://github.com/antvis/S2/pull/2932 修复箭头的展示后, 由于层级发生变动, 原 sub-menu 变为 menu, 会导致自定义 menu 的 hook 未触发.

🖼️ Screenshot

Before	After

🔗 Related issue link

🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
antvis-s2	❌ Failed (Inspect)			Oct 28, 2024 9:04am

github-actions[bot] commented 3 weeks ago

Size Change: +24 B (+0.01%)

Total Size: 335 kB

Filename	Size	Change
`./packages/s2-core/dist/index.min.js`	236 kB	-14 B (-0.01%)
`./packages/s2-react/dist/index.min.js`	70.9 kB	+38 B (+0.05%)

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `./packages/s2-core/dist/style.min.css` | 388 B | | `./packages/s2-react/dist/style.min.css` | 3.77 kB | | `./packages/s2-vue/dist/index.min.js` | 22.9 kB | | `./packages/s2-vue/dist/style.min.css` | 1.85 kB |

_{compressed-size-action}

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.79%. Comparing base (ecdc9c8) to head (7725bad). Report is 465 commits behind head on next.

Files with missing lines	Patch %	Lines
...act/src/components/tooltip/components/operator.tsx	66.66%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## next #2946 +/- ## ========================================== + Coverage 75.77% 80.79% +5.02% ========================================== Files 257 180 -77 Lines 11994 10434 -1560 Branches 2464 2369 -95 ========================================== - Hits 9088 8430 -658 + Misses 1398 556 -842 + Partials 1508 1448 -60 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lijinke666 commented 3 weeks ago

:tada: This PR is included in version @antv/s2-v2.0.0-next.31 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

lijinke666 commented 3 weeks ago

:tada: This PR is included in version @antv/s2-react-v2.0.0-next.30 :tada:

The release is available on:

Your semantic-release bot :package::rocket: