fix: 修复表格卸载时 G 图形实例未销毁的问题

antvis / S2

⚡️ A practical visualization library for tabular analysis.

https://s2.antv.antgroup.com

MIT License

1.49k stars 196 forks source link

fix: 修复表格卸载时 G 图形实例未销毁的问题 #2973

Closed lijinke666 closed 1 week ago

lijinke666 commented 1 week ago

👀 PR includes

✨ Feature

[ ] New feature

🎨 Enhance

[ ] Code style optimization
[ ] Refactoring
[ ] Change the UI
[ ] Improve the performance
[ ] Type optimization

🐛 Bugfix

[ ] Solve the issue and close #0

🔧 Chore

[ ] Test case
[ ] Docs / demos update
[ ] CI / workflow
[ ] Release version
[ ] Other ()

📝 Description

🖼️ Screenshot

Before	After
❌	✅

🔗 Related issue link

🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
antvis-s2	❌ Failed (Inspect)			Nov 13, 2024 6:45am

github-actions[bot] commented 1 week ago

Size Change: 0 B

Total Size: 336 kB

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `./packages/s2-core/dist/index.min.js` | 236 kB | | `./packages/s2-core/dist/style.min.css` | 388 B | | `./packages/s2-react/dist/index.min.js` | 70.9 kB | | `./packages/s2-react/dist/style.min.css` | 3.77 kB | | `./packages/s2-vue/dist/index.min.js` | 23 kB | | `./packages/s2-vue/dist/style.min.css` | 1.85 kB |

_{compressed-size-action}

lijinke666 commented 1 week ago

这样改有问题, revert

lijinke666 commented 1 week ago

:tada: This PR is included in version @antv/s2-v2.0.0-next.33 :tada:

The release is available on:

Your semantic-release bot :package::rocket: