fix cant add edge when use customLayOut

antvis / XFlow

React component for building interactive diagrams.

https://x6.antv.antgroup.com/xflow/guide/introduction

MIT License

573 stars 235 forks source link

fix cant add edge when use customLayOut #232

Closed arthur657834 closed 2 years ago

arthur657834 commented 2 years ago

fix cant add edge when use customLayOut and node port is at left/right issue: https://github.com/antvis/XFlow/issues/231

Description

Compatible method addEdge with custom layouts and when node link piles are distributed left and right

Motivation and Context

Types of changes

[*] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[*] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 9f2efb1bac13de5ddee3479d07b4634f62e1f448

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

| Name | Type | | --------------------- | ----- | | @antv/xflow-core | Patch | | @antv/xflow | Patch | | @antv/xflow-extension | Patch | | @antv/xflow-hook | Patch | | xflow-quick-start-cra | Patch | | xflow-quick-start-umi | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

xflow-bot[bot] commented 2 years ago

👋 @arthur657834

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

fix: don't overwrite prevent_default if default wasn't prevented
feat: add graph.scale() method
docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

Follow the TypeScript, JavaScript, CSS and React coding style.
Run npm run lint locally to catch formatting errors earlier.
Document any user-facing changes you've made.
Include tests when adding/changing behavior.
Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

xflow-bot[bot] commented 2 years ago

👋 @arthur657834

Congrats on merging your first pull request! 🎉🎉🎉