fix(flow-chart): fix cannot copy/paste edges within group

lijinke666 commented 1 year ago

Description

修复开启群组后, 无法复制/粘贴群组里面的连接线, 目前发现有三个问题

复现地址: https://xflow.antv.vision/docs/tutorial/solutions/flow

复制: getSelectedCells 里面不包含 edges, 按照官网的介绍连接线也属于 edges, 但是却拿不到

不知道是我理解有误, 还是 XFlow 依赖的 X6 对应版本有 bug, 所以修改为 getSelectedCells + getEdges 组合的方式 (我看 parseCells 已经有相应 edges 过滤的处理) 保证复制到正确的东西

粘贴: 断点看下来, 复制拿到的 source 和 target 并不是类型定义的 string, 而是 { port: string, cell: string }, 而 nodeMappingRecord 的 key 又是 string, 导致始终无法拿到需要粘贴 edges, 然后拿到的配置又是透传给 X6, 里面包含原 edge 的 id, 又会导致无法渲染

空节点: 空节点没有 label 的时候也会拼一个 xx_copied 的名称, 感觉有点奇怪, 不知道是故意的还是啥

能力有限, 只能定位到这里的, 不确定这样修改会不会碰伤其他逻辑, 也没看到有任何的单测, 如果这个库还要维护的话, 请大佬 review 一下, 或者给出更好的解决方式

修复前	修复后

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 084e84bd82339cb1cdce6983f2062cecaf913114

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

xflow-bot[bot] commented 1 year ago

👋 @lijinke666

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

fix: don't overwrite prevent_default if default wasn't prevented
feat: add graph.scale() method
docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

Follow the TypeScript, JavaScript, CSS and React coding style.
Run npm run lint locally to catch formatting errors earlier.
Document any user-facing changes you've made.
Include tests when adding/changing behavior.
Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

xflow-bot[bot] commented 1 year ago

👋 @lijinke666

Congrats on merging your first pull request! 🎉🎉🎉

antvis / XFlow