antvis / XFlow

React component for building interactive diagrams.
https://x6.antv.antgroup.com/xflow/guide/introduction
MIT License
584 stars 239 forks source link

CanvasToolbar 画布工具栏 isVisible 不生效 #357

Closed zhuqiaoz closed 1 year ago

zhuqiaoz commented 1 year ago

问题描述

  1. 在CanvasToolbar 中设置isVisible: true。工具栏中元素依然可见。

重现链接

https://codesandbox.io/s/ji-chu-shi-yong-fang-fa-forked-8t151v

重现步骤

1.toolbar-config.tsx 中设置元素的isVisible 不生效

预期行为

根据依赖getToolbarState 动态显示

平台

屏幕截图或视频(可选)

No response

补充说明(可选)

  1. 源码 https://github.com/antvis/XFlow/blob/master/packages/xflow-extension/src/canvas-toolbar/render-components/toolbar-item.tsx#L63 hidden={!item} 应该是hidden={!item.isVisible}把
xflow-bot[bot] commented 1 year ago

👋 @zhuqiaoz

Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

xflow-bot[bot] commented 1 year ago

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the AntV community! 💪💯

xflow-bot[bot] commented 1 year ago

Hey again!

It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Please keep in mind that I’m only a robot 🤖, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the AntV community! 💪💯

xflow-bot[bot] commented 5 months ago

This thread has been automatically locked because it has not had recent activity.

Please open a new issue for related bugs and link to relevant comments in this thread.