search

antvis / antvis.github.io

🔜 AntV 新站点！
https://antv.vision
Other
419 stars 51 forks source link

test: preview #85

Closed xrkffgg closed 3 years ago

xrkffgg commented 3 years ago

I'm doing a test and will close a little bit.

github-actions[bot] commented 3 years ago

🎊 PR Preview 256863eec7a54c609690fc370f2c1ac2ff1016b9 has been successfully built and deployed to https://antvis-antvis-github-io-preview-pr-85.surge.sh

:clock1: Build time: 274.21s

🤖 By surge-preview

xrkffgg commented 3 years ago

@afc163 @kerm1it 这好像没预览成功呢

我试了几个都不行，预览界面还保持原状

https://github.com/ant-design/pro-components/pull/923 https://github.com/zoo-js/zoo-issue-helper/pull/51 https://github.com/ant-design-colorful/ant-design-colorful/pull/18

xrkffgg commented 3 years ago

我用法不对？

afc163 commented 3 years ago

@xrkffgg 貌似确实有问题，pull_request_target 指向了原始分支。

cc @shaodahong

shaodahong commented 3 years ago

一个已知的问题，https://github.com/actions/checkout/pull/321

对于 PR 来说可以尝试这个方案 https://github.com/actions/checkout/blob/f16eddee8410930a20309c41063631c4177643a5/README.md#checkout-pull-request-on-pull_request_target

xrkffgg commented 3 years ago

https://github.com/zoo-js/zoo-issue-helper/pull/54

加上这个可以了

with: ref: refs/pull/${{ github.event.pull_request.number }}/merge

afc163 commented 3 years ago

能在 surge_preview 里解决么？不然又要发一堆 PR 了：

https://github.com/ant-design/ant-design/pull/27453

image
xrkffgg commented 3 years ago

感觉不需用 push 触发啊

image

shaodahong commented 3 years ago

应该不行，还没到 surge_preview 这一步，其他的仓库暂时先不动，改这个库试试，后续没问题我来提 PR 吧

xrkffgg commented 3 years ago

push 检测了 build 正常，生成不了 url 来预览呢