search

antvis / g-webgl-compute

A GPGPU implementation based on WebGL.
MIT License
144 stars 15 forks source link

fix(core): fix #32 #33

Open CarterLi opened 3 years ago

CarterLi commented 3 years ago

Babel somehow can't recognize TypeScript specific type import/export, and generates invalid esm code which breaks projects use vite.

Ref: https://github.com/antvis/G6/issues/2465

CarterLi commented 3 years ago

@xiaoiver Could you please have a look on this PR? The issue I'm addressing is blocking our project migrating to vite

CarterLi commented 3 years ago

@xiaoiver ping

CarterLi commented 3 years ago

@xiaoiver ping

cliffordfajardo commented 2 years ago

@xiaoiver 看起来这个问题已在下面列出的问题中得到解决

团队的人可以关闭这个问题吗？这将有助于在寻找要修复的软件错误时保持 github 问题的清洁 🙏

English Translation: It looks like this issue was resolved in the issue listed below:

CarterLi commented 2 years ago

并没有解决。

GWebGPUEngine/packages/core/src/index.ts

这个文件从去年末就没动过了，这个PR是今年年初开的，怎么能解决？现在这问题没人提了，是因为 G6 把这个问题绕过去了，但不代表这个仓库的代码没问题

cliffordfajardo commented 2 years ago

好的，谢谢你的澄清