antvis / gatsby-theme-antv

⚛️ Polished Gatsby theme for documentation site
https://gatsby-starter-theme-antv.antv.vision/zh
Other
344 stars 57 forks source link

Interactive document #231

Closed afc163 closed 3 years ago

afc163 commented 4 years ago

@xingwanying PR 可以提前建出来,方便预知 ci 和冲突情况。

github-actions[bot] commented 4 years ago

🎊 PR Preview fd8963eddbf2b06d8ae583909bc08d85fcf4d13c has been successfully built and deployed to https://antvis-gatsby-theme-antv-preview-pr-231.surge.sh

:clock1: Build time: 397.253s

🤖 By surge-preview

gatsby-cloud[bot] commented 4 years ago

Gatsby Cloud Build Report

gatsby-theme-antv

:tada: Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

:clock1: Build time: 10m

Performance

Lighthouse report

Metric Score
Performance :large_orange_diamond: 20
Accessibility :large_orange_diamond: 75
Best Practices :green_heart: 93
SEO :large_orange_diamond: 75

:link: View full report

afc163 commented 3 years ago
image

这个感觉还是要默认展现出来,tooltip 靠右展示。

afc163 commented 3 years ago
image

左右布局不应该写死,搜索框和收起应该靠右,建议用 flex 写。

afc163 commented 3 years ago

https://gatsbythemeantv-interactivedocumentdev.gtsb.io/zh/examples/basic#basic

一进入的时候,左边的 skeleton 周围应该有 padding。

右边是不是也应该有 skeleton?

而且应该根据页面布局来画 skeleton。

afc163 commented 3 years ago
image

这里的标题要在 demo 页面里面透出,不然不知道是属于哪个分类的。

xingwanying commented 3 years ago
image

这个感觉还是要默认展现出来,tooltip 靠右展示。

文字特别多的也全部展示?还是设置最大值多的省略?

afc163 commented 3 years ago
image

图标没对齐。

afc163 commented 3 years ago
image

切换设备后,出现横向滚动条。

afc163 commented 3 years ago

https://gatsbythemeantv-interactivedocumentdev.gtsb.io/zh/examples/basic#ts-demo

image
afc163 commented 3 years ago
image image image image image image
afc163 commented 3 years ago

没有 API 的 demo 长什么样?比如 G2/G6 这些 demo:https://g6.antv.vision/zh/examples/tree/compactBox#basicCompactBox

xingwanying commented 3 years ago

https://g6.antv.vision/zh/examples/tree/compactBox#basicCompactBox

没有的默认两栏 image