search

antwankakki / FabricView

A new canvas drawing library for Android. Aims to be the Fabric.js for Android. Supports text, images, and hand/stylus drawing input. The library has a website and API docs, check it out
http://antwankakki.github.io/FabricView/
Apache License 2.0
1.04k stars 183 forks source link

Multiple quality improvements #14

Closed m-ezzat closed 8 years ago

m-ezzat commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1068 - Unused private fields should be removed squid:S2293 - The diamond operator ("<>") should be used squid:ClassVariableVisibilityCheck - Class variable fields should not have public accessibility

You can find more information about the issues here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S1068 https://dev.eclipse.org/sonar/coding_rules#q=squid:S2293 https://dev.eclipse.org/sonar/coding_rules#q=squid:ClassVariableVisibilityCheck

Please let me know if you have any questions.

M-Ezzat

m-ezzat commented 8 years ago

I am not sure whether you do not agree with these changes or not. Please close this PR if not.

antwankakki commented 8 years ago

No its just as you can see by looking at my history, i havent been active on github due to some life reasons