search

anudeepND / whitelist

A simple tool to add commonly white listed domains to your Pi-Hole setup.
MIT License
4.22k stars 282 forks source link

Add missing command to Automated Update #119

Closed borzaka closed 4 years ago

anudeepND commented 4 years ago

I think it is better to remove sudo ./whitelist.sh because the cron will execute the script and user need not have to manually execute the script, what do you think @borzaka @SuperSandro2000 ?

borzaka commented 4 years ago

That's true, but for the first time it won't be executed right away. The user has to wait until the last day of the week. I think on the first install user wants to use the list, and not wait.

anudeepND commented 4 years ago

@borzaka sudo whitelist/scripts/whitelist.sh is enough to run the script, sudo ./whitelist.sh is not necessary

borzaka commented 4 years ago

@anudeepND Not from the "For Automated Update" section, because there is no cd whitelist/scripts instruction there. So you need to change directory, or run the script by include the directory.