search

anudeepND / whitelist

A simple tool to add commonly white listed domains to your Pi-Hole setup.
MIT License
4.18k stars 281 forks source link

Add python3 shebang #169

Closed Obihoernchen closed 4 years ago

Obihoernchen commented 4 years ago

With a proper shebang you don't need python3 whitelist.py anymore. A simple ./whitelist.py is sufficient

anudeepND commented 4 years ago

I would expect that #!/usr/bin/env python3 should work on almost all systems. However, some systems has python for python3, they don't provide a python3 alias. What do you think @Obihoernchen ?

Obihoernchen commented 4 years ago

That's not a problem. You could still use python whitelist.py in this case, as this "overwrites" the shebang. You can test with #!/usr/bin/env python4 or something like this in the shebang.

And yes, every sane systems should have a python3 alias anyways ;)

btw without the shebang the current crontab entry in the readme would not work: 0 1 * * */7 root /opt/whitelist/scripts/whitelist.py

anudeepND commented 4 years ago

@Obihoernchen Ah! got it. Merging