Full redo of #170 (my first attempt at improving logic) - Githubissues

anudeepND / whitelist

A simple tool to add commonly white listed domains to your Pi-Hole setup.

MIT License

4.18k stars 281 forks source link

Full redo of #170 (my first attempt at improving logic) #172

Closed mwoolweaver closed 3 years ago

mwoolweaver commented 3 years ago

but accomplished in less commits so changes are easier to see

pretty much https://github.com/anudeepND/whitelist/pull/170#issuecomment-687565149

If no changes

whitelist-output-no-add

If user added and if left behind from previous script version and if new added

Logic Test

mwoolweaver commented 3 years ago

@anudeepND If you choose to merge this after testing you'll have to change line 72 & 73 of whitelist.py to your master again

whitelist_remote_url = 'https://raw.githubusercontent.com/anudeepND/whitelist/master/domains/whitelist.txt'
remote_sql_url = 'https://raw.githubusercontent.com/anudeepND/whitelist/master/scripts/domains.sql'

I only changed so it could be proved to work other places while testing, since domains.sql also changed some

anudeepND commented 3 years ago

@mwoolweaver Thanks for the PR. Merging