less counting, proper list handling, adds to NOT default group, and more comments - Githubissues

anudeepND / whitelist

A simple tool to add commonly white listed domains to your Pi-Hole setup.

MIT License

4.18k stars 281 forks source link

less counting, proper list handling, adds to NOT default group, and more comments #184

Closed mwoolweaver closed 3 years ago

mwoolweaver commented 3 years ago

This P/R accomplishes the following:

better version of anudeepND/whitelist/pull/183
close #179
- Script will now create group and use for all domains added by script done by https://github.com/anudeepND/whitelist/pull/184/commits/471337552f1d387dd06741ccd416891bdef564a3. This was a bit of a struggle because of pi-hole/docs/issues/412 which was fixed with pi-hole/docs/issues/411. Hopefully my struggles will save someone time in the future.
close #180
- the sqlite3 statement was missing entries with a null comment. fixed with https://github.com/anudeepND/whitelist/pull/184/commits/bd0ee5e4742396c8b7c04c67972798bd5852050d
partially address #181

Can we get some better comments in whitelist.py?
- add more (but maybe not better) comments

Do this to test work-ability

curl -sSL https://raw.githubusercontent.com/mwoolweaver/whitelist/master/scripts/whitelist.py | sudo /usr/bin/env python3

anudeepND commented 3 years ago

@mwoolweaver Sorry for the late reply, thanks for this PR :)