anudit / eauth-eip

Draft EIP for Standards and Best Practices around Authentication with Ethereum.
MIT License
5 stars 1 forks source link

Discussion thread #1

Open brantlymillegan opened 3 years ago

makoto commented 3 years ago
let recoveredAddress = recoverAddress(arrayify(hashMessage(data)), signature);

This is under the assumption that the address is EOA. Can we make use of ERC1271 which supports contract-based accounts?

https://www.npmjs.com/package/is-valid-signature is a library that abstracted the logic. It works on most contract-based accounts except Gnosis Safe which hasn't supported ERC1271 yet.

const resolverAddress = "0x3671aE578E63FdF66ad4F3E12CC0c0d71Ac7510C";

const addresses = ['0xd8da6bf26964af9d7eed9e03e53415d37aa96045', '0x983110309620d911731ac0932219af06091b6744']

Looks like 0x3671.. is ReverseRecord contract which I deployed a while back. Even though I understand that this will help looking up multiple names in one function call, isn't it irrelevant to the specification?