search

anufrievroman / calcure

Modern TUI calendar and task manager with minimal and customizable UI.
https://anufrievroman.gitbook.io/calcure
MIT License
1.51k stars 43 forks source link

Use icalendar instead of ics #74

Closed jose1711 closed 9 months ago

jose1711 commented 9 months ago

Fixes #66

anufrievroman commented 9 months ago

Thank you! I'll test it a bit, and then I'll merge it to main. I wonder if we should keep both systems as alternatives because for different people ics parsing it is not always working well, depending on the specific fields etc. Also, there are some protective checks and error catches in the code specific to ics library issues, maybe we can get rid of them as well.

jose1711 commented 9 months ago

rebased on top of main

jose1711 commented 9 months ago

I wonder if we should keep both systems as alternatives because for different people ics parsing it is not always working well, depending on the specific fields etc.

Is there a concrete example where icalendar performs worse than ics module?

anufrievroman commented 9 months ago

Not really, no. That's why for now I merged as is, just replacing the whole system. It's just previously when we introduced ics parsing, there were bunch of people who had strange issues. Anyways, let's publish version 3.0 with icalendar and see if anyone complains.