search

anufrievroman / freepaths

Monte Carlo simulator of phonon and heat transport in nanostructures
https://anufrievroman.gitbook.io/freepaths
Other
14 stars 4 forks source link

Bug in parabola bottom #22

Closed phigas closed 7 months ago

phigas commented 7 months ago

The collimating behaviour of the bottom parabola is incorrect. The scattering seems to be happening in the wrong direction.

bottom focussing top collimating top focussing bottom collimating

phigas commented 7 months ago

The images with red lines through the structures are directional phonon sources. These are focussing cases. The other ones are collimating cases where the phonons are generated in the focus of the parabola

anufrievroman commented 7 months ago

I checked, yes, apparently the bottom parabola works when used to collimate (that's why we never noticed before) but fails when used to focus. In fact, the scattering code for top and bottom parabola is the same, which is probably wrong. I'll need to check it more seriously. But since now we can launch phonons from any side, maybe one working parabola is enough 😆

anufrievroman commented 7 months ago

Looks like I fixed it, although I didn't test extensively. image image So, I'll close it for now.