search

anujkhare / iregnet

7 stars 12 forks source link

Optimization #59

Open RoverVan opened 7 years ago

tdhock commented 7 years ago

the travis build is failing because the linker on the travis VM can not find libopenblas. https://travis-ci.org/anujkhare/iregnet/builds/242848673#L735

It is not installed by default, but it is included in the "libopenblas-dev" debian/ubuntu pkg, which you can tell travis to install via https://docs.travis-ci.com/user/languages/r/#APT-packages

RoverVan commented 7 years ago

Hey @anujkhare , I wrote a blog with benchmark figures of new iregnet. As the result of benchmark, new iregnet gets great performance than before. I think it is time to merge the pull request.

tdhock commented 7 years ago

please resolve conflicts first

RoverVan commented 7 years ago

Ok @tdhock , i just resolved the conflicts. However, some errors happened on travis because RcppArmadillo just updated a few days ago and required higher c++ compiler version. So I changed the c++ compiler version by updating travis.yml and the problem was resolved.

tdhock commented 7 years ago

@anujkhare is it OK to merge with master? Looks fine to me.

anujkhare commented 7 years ago

@RoverVan great work with this! Just give me a bit, I am looking through it.

tdhock commented 5 years ago

hi @anujkhare can you please review and approve/merge if it is ok?

anujkhare commented 5 years ago

Well, my review is 2 years too late, but I'll go through it regardless. We can decide whether or not to pick anything up based on how much time we have.