search

anujkhare / iregnet

7 stars 12 forks source link

future instead of foreach please #69

Closed tdhock closed 5 years ago

tdhock commented 5 years ago

Hi in recent years it has become apparent that the future framework should be preferred over foreach, so I would suggest using future.apply::future_lapply instead of foreach in cv.iregnet. For a usage example see https://github.com/tdhock/penaltyLearning/blob/master/R/IntervalRegression.R#L192

is that ok with you @anujkhare ?

is that something you could implement in a new PR this summer? @theadityasam

theadityasam commented 5 years ago

Yes, will look into it

theadityasam commented 5 years ago

https://github.com/anujkhare/iregnet/blob/master/R/cv.iregnet.R#L119