search

anunpanya / ESP8266_QRcode

102 stars 53 forks source link

Open interface #1

Closed squix78 closed 8 years ago

squix78 commented 8 years ago

Totally forgot: wonderful work! I was thinking about writing a library myself but when I found yours I immediatelly had to try it out! Thanks a lot! Now here I have a few suggestions for improvement. You don't allow the library user to alter the pins or the protocol of the used display. I opened up the constructor in order to pass in a customized display object. Now you can pass in a 0.96" or 1.3" display with a I2C or a SPI interface. I also added a library.json file so it can be indexed by platformio: http://docs.platformio.org/en/latest/librarymanager/config.html

FWeinb commented 8 years ago

I just fished exactly the same modification! I would really like to see this in the library, great work!