search

anura-engine / anura

Anura Engine
Other
384 stars 78 forks source link

Use imgui as an external dependency #300

Closed SnarkBoojum closed 4 years ago

SnarkBoojum commented 4 years ago

The current use of imgui through a git submodule (which needs to be fetched using 'git submodule update') isn't ideal :

  1. After all, it's a dep like others, so why embed it?
  2. It's a quite old version of imgui : upstream improved it since.
DDR0 commented 4 years ago

I agree, the submodule is not ideal.

However, for now, since upstream won't compile because things changed I think that's a good reason not to use it. Regardless of any improvements. The person who integrated imgui in the first place hasn't been active in a while either, so I don't know why it was done like this in the first place I'm afraid.

It's unlikely we'll upgrade imgui ourselves at this point, given most of the use of it is in our dev tools. So we do recommend using the submodule version for now.

On Sun., Jun. 21, 2020, 11:35 p.m. Julien Puydt, notifications@github.com wrote:

The current use of imgui through a git submodule (which needs to be fetched using 'git submodule update') isn't ideal :

  1. After all, it's a dep like others, so why embed it?
  2. It's a quite old version of imgui : upstream improved it since.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/anura-engine/anura/issues/300, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGSTI254HJWSQSAPJ7MC33RX33SXANCNFSM4OEIR2XA .

DDR0 commented 4 years ago

Ah, this is a duplicate of issue #249.

DDR0 commented 4 years ago

Uh, anyway, if you'd like to talk to us in person, we're over on Discord at https://discord.gg/2MwMhdd. Might be more timely than the bugtracker here. :slightly_smiling_face: