search

anuraag016 / Jest-Coverage-Diff

Jest Coverage report diff as a comment for Pull requests
MIT License
59 stars 46 forks source link

Feature: Use same comment. Also don't pick removed files for delta validation #30

Closed anuraag016 closed 2 years ago

anuraag016 commented 3 years ago

Adds feature requested #27 Fixes bug raised #29

therynamo commented 3 years ago

So would the messageToPost need to have the sha from the commit in it in order to see that reflected in the comment?

Some times it is valuable - especially if you push multiple commits in succession - to see which commit the comment is actually reflecting on. I think it is fine to put this on the user if we don't want any more application code to be developed here. That being said - would also be really nice to have the sha on that comment by default.

Though - you are the maintainer - so I leave that up to you :)

therynamo commented 3 years ago

Any updates on the trails of this? 😄