anuraghazra / github-readme-stats

:zap: Dynamically generated stats for your github readmes
https://github-readme-stats.vercel.app
MIT License
70.04k stars 23.27k forks source link

Trophies Card #3613

Open RokeJulianLockhart opened 10 months ago

RokeJulianLockhart commented 10 months ago

Is your feature request related to a problem? Please describe.

I currently use https://github-profile-trophy.vercel.app/?username=RokeJulianLockhart&theme=default&no-frame=false&no-bg=false&margin-w=4, but it doesn't support a transparent theme.

Describe the solution you'd like

Create a Trophy card.

Describe alternatives you've considered

https://github-profile-trophy.vercel.app/?username=RokeJulianLockhart&theme=default&no-frame=false&no-bg=false&margin-w=4

Additional context

https://github.com/RokeJulianLockhart#statistics

qwerty541 commented 10 months ago

Hey, @RokeJulianLockhart! Thanks for your feature request.

To be honest I don't think that the need of transparent theme is enough reason to duplicate trophy card inside this repository. The much easier solution will be submitting feature request to the https://github.com/ryo-ma/github-profile-trophy. They already support customizing card with themes, so adding a new one hardly will be a concern.

Recently we have discussed with other maintainers very similar issue. It was the addition of streak stats card which was already implemented in another project. This feature was rejected with the following conclusion https://github.com/anuraghazra/github-readme-stats/pull/3338#issuecomment-1762966088 .

In my opinion addition of trophy card only make sense in case if someone will create an unique design.

Of course let's wait for other maintainers input about that.