search

anuragraghavan / franca

Automatically exported from code.google.com/p/franca
0 stars 0 forks source link

import does not validate model consistency #62

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Franca raises an error if several TypeCollections of the same name occur in one 
single package namespace.

e.g. this statement obviously causes the expected error in Franca 0.8.8:
typeCollection x {
    typedef a is UInt16
}
typeCollection x {
    typedef a is UInt16
}

If the same situation is remodelled using import there is no error. The 
following example does NOT raise an error in Franca.

<<testinterface1.fidl>>:
package testinterface
typeCollection x {
    typedef a is UInt16
}

<<testinterface2.fidl>>:
package testinterface
import testinterface.* from "testinterface1.fidl"
typeCollection x {
    typedef a is UInt16
}

It is suggested to provide model validation across imports to ensure 
specification consistency in Franca.

Original issue reported on code.google.com by manfred....@bmw.de on 9 Sep 2013 at 11:33

GoogleCodeExporter commented 9 years ago

Original comment by klaus.birken@gmail.com on 20 Sep 2013 at 3:28

GoogleCodeExporter commented 9 years ago 
Commit 2ec85bf solves the issue basically. Still the cross-file validation of 
anonymous type collections has to be checked.

Original comment by klaus.birken@gmail.com on 23 Sep 2013 at 11:28

GoogleCodeExporter commented 9 years ago 
Commit 14a0c47 provides cross-file validation of anonymous type collections. 
Thus, the issue is fixed and will be released with 0.8.10.

Original comment by klaus.birken@gmail.com on 23 Sep 2013 at 12:17