search

anuragsoni / routes

typed bidirectional router for OCaml/ReasonML web applications
https://anuragsoni.github.io/routes/
BSD 3-Clause "New" or "Revised" License
145 stars 11 forks source link

Add bucklescript support #101

Closed Risto-Stevcev closed 4 years ago

anuragsoni commented 4 years ago

Thank you! Is there a recommended CI setup for bucklescript projects? I'm guessing the github-actions for node should be a good starting point.

On a related note what's the recommended publishing workflow for bucklescript libraries?

Risto-Stevcev commented 4 years ago

You can just use the default node build for travis, see the travis example here on bs-webapi-incubator, which is a popular official reasonml lib that provides bindings to web apis.

The reason it works is because the travis build by convention will check the package.json and build (and test) with the default build and test commands: https://github.com/reasonml-community/bs-webapi-incubator/blob/master/package.json#L17-L22

anuragsoni commented 4 years ago

You can just use the default node build for travis, see the travis example here on bs-webapi-incubator, which is a popular official reasonml lib that provides bindings to web apis.

Perfect! Thanks again for the patch. I'll add the CI setup and merge this later tonight. I can work on getting this on npm/github npm registry after that.

anuragsoni commented 4 years ago

This was added as part of #104