anuriq / chef-kibana5

Chef cookbook for installing Kibana 5.x.x
https://supermarket.chef.io/cookbooks/kibana5
Apache License 2.0
5 stars 15 forks source link

Allow arbitrary number of kibana config options #16

Closed gevorg15 closed 6 years ago

gevorg15 commented 7 years ago

Allow arbitrary number of kibana config options to be passed into the configure resources in the default recipe. This allows you to control the installation config via just attributes, if desired.

anuriq commented 7 years ago

Hi @gevorg15

I see what was your intent here, but default.rb recipe is more like an example, than main way of using this cookbook. As written in README, it is more preferable to use resources directly.

And when you use resource directly, you can see that it accepts hash, so you can provide your own configuration options easily without involving attributes.

What do you think?

gevorg15 commented 7 years ago

Using the resource is nice but that means writing a wrapper cookbook. With the proposed changes, you can get away without writing a wrapper and just setting a few attributes in your environment and roles.