search

anuriq / chef-kibana5

Chef cookbook for installing Kibana 5.x.x
https://supermarket.chef.io/cookbooks/kibana5
Apache License 2.0
5 stars 15 forks source link

Rename deprecated elasticsearch.ssl.ca property #38

Open 4b3l opened 6 years ago

4b3l commented 6 years ago

Config key \"elasticsearch.ssl.ca\" is deprecated. It has been replaced with \"elasticsearch.ssl.certificateAuthorities\

anuriq commented 6 years ago

hi there @4b3l your change will affect everyone using this cookbook. shall we make a condition, e.g. if kibana version is more than x.x then change it?

4b3l commented 6 years ago

Hi Azat,

That is probably the better option so we don't break backwards comaptibility. The property looks to have changed after version 5.6.

On 10 July 2018 at 09:45, Azat Khadiev notifications@github.com wrote:

hi there @4b3l https://github.com/4b3l your change will affect everyone using this cookbook. shall we make a condition, e.g. if kibana version is more than x.x then change it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anuriq/chef-kibana5/pull/38#issuecomment-403747521, or mute the thread https://github.com/notifications/unsubscribe-auth/AlRwTg5cZPm9S5tJ6GgRaWECXvyko5z2ks5uFGmUgaJpZM4VHZms .

TheKatarGit commented 6 years ago

@4b3l According to kibana docs, they deprecated this in 5.3 and later. Kibana 5.2 has this config line. Kibana 5.3 has not. Also, there's a difference in types. Elasticsearch.ssl.ca was a string, and Elasticsearch.ssl.certificateAutorities is an array of strings. Could you please add if statement using default['kibana5']['version'] attribute to alter the behaviour of template generation?