Project Feedback! - Githubissues

codepathreview commented 7 years ago

You're missing the required story:

User is displayed the *username*, name, and body for each tweet

Please update and let us know asap

anushreeag commented 7 years ago

Hi, Thanks for your review . Do i need to record the videos for all other user stories ? or if i show one video with the fix is ok ?

anushreeag commented 7 years ago

Hi,

Thanks for your review Fixed the issue " username, name, and body for each tweet " is displayed. I have posted only one video with this fix. Please let me know if I need to record videos with this fix for other user stories demo as well.

Regards Anushree

codepathreview commented 7 years ago

Thanks for fixing it! Great work overall. A few notes after checking out the code:

Nice effort on UI polish but overall, the font doesn't do justice for a clean UI. Consider using some other theme to make it more aligned with Twitter brand colors.
Good to see you were able to format the timestamp cleanly (consider using short format:2h)
Nice to see you used the SwipeRefreshLayout for easy timeline refreshes
Good job on getting the new tweet displayed on timeline
Nice touch with the character count being displayed while the user composes a tweet
Glad to see you made the compose activity into a dialog instead
Good job using RecyclerView instead of ListView
Consider adding progress bars to your app whenever a network request goes out

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android. /cc @codepathreview

anushreeag / MyTwitter

Project Feedback! #1