search

anusii / keypod

A template flutter app using Solid pods.
GNU General Public License v3.0
1 stars 2 forks source link

KEYPOD: Fails in logging as new user #80

Open zheyxu opened 6 months ago

zheyxu commented 6 months ago

Description

Keeps failing on https://github.com/anusii/solidpod/blob/b90ede5e7bf362f4ed34e953eb79bba5eed0ffb1/lib/src/solid/utils/misc.dart#L203 as webId is null.

The issue is that as a new user, webId is trying to get from secureStorage. It should be fixed.

cdawei commented 6 months ago

I am not able to reproduce this problem using the following steps (with current dev branch):

  1. Start keypod and click the Register button
  2. Follow the links on the pop up webpage to create a new POD and login

I did notice the logging animation is now on top of the POD initialisation page and I have to manually click the Cancel button to dismiss it.

What are the steps leading to the webId null error in your test, @zheyxu ?

zheyxu commented 6 months ago

In MacOS it raises the webId null error as I followed the same steps:

  1. Start keypod and click the Register button
  2. Follow the links on the pop up webpage to create a new POD and login

But running in android it works. And I noticed that there is no LOGOUT button running the app in android. @cdawei

Image

cdawei commented 6 months ago

In MacOS it raises the webId null error as I followed the same steps:

  1. Start keypod and click the Register button
  2. Follow the links on the pop up webpage to create a new POD and login

Thanks @zheyxu , could you put the full error messages here for us to have a look?

But running in android it works. And I noticed that there is no LOGOUT button running the app in android.

The Logout From Remote Solid Server button in your screenshot is the logout button.

zheyxu commented 6 months ago

The full error message is Exception has occurred. _AssertionError ('package:solidpod/src/solid/utils/misc.dart': Failed assertion: line 150 pos 10: 'webId != null': is not true.)

cdawei commented 6 months ago

Zheyuan mentioned that updating flutter secure storage to the latest version fixed the issue. Zheyuan updated that this does not seem to fix the issue.

gjwgit commented 6 months ago

Can this be closed now?

cdawei commented 6 months ago

This will be closed with a pull request primarily addressing another issue.

gjwgit commented 6 months ago

Which branch will fix this? Thanks.

cdawei commented 6 months ago

It will be interesting to know if this issue is still there (in the Mac app) now that webID is managed together with the authentication data.