anusii / podnotes

GNU General Public License v3.0
2 stars 3 forks source link

PREP: Fix ALL issues reported by `make prep` in PODNOTES #101

Open gjwgit opened 8 months ago

gjwgit commented 8 months ago

Description

In preparation of moving code into the support packages, please ensure all issues are resolved for PODNOTES so that make prep reports no problems.

Need to remove all ignore: and add license to every file, with proper DESCRIPTION and AUTHOR.

Why

So that the PODNOTES package can stand as the definitive guide to writing PODs based apps.

gjwgit commented 8 months ago

I've fixed, single quotes, sorted imports, etc. Currently seeing:

flutter analyze
Analyzing podnotes...                                                   

   info • Use interpolation to compose strings and values • lib/common/rest_api/res_permission.dart:350:33 • prefer_interpolation_to_compose_strings
   info • Use interpolation to compose strings and values • lib/common/rest_api/res_permission.dart:693:33 • prefer_interpolation_to_compose_strings
   info • Use an initializing formal to assign a parameter to a field • lib/constants/rdf_functions.dart:307:5 • prefer_initializing_formals
   info • Don't use 'BuildContext's across async gaps • lib/login/screen.dart:204:25 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps • lib/login/screen.dart:246:17 • use_build_context_synchronously
   info • Don't use 'BuildContext's across async gaps • lib/login/screen.dart:256:17 • use_build_context_synchronously

6 issues found. (ran in 1.2s)