search

anvaka / graph-drawing-libraries

Trying to compare known graph drawing libraries
https://anvaka.github.io/graph-drawing-libraries/#/all
587 stars 44 forks source link

Implement OAuth component #5

Closed anvaka closed 10 years ago

anvaka commented 10 years ago

GitHub has a rate limit for non-authenticated calls: 60 requests per hour. Authenticated users can make 5,000 calls per hour.

We need a widget which would let users authenticate themselves.

anvaka commented 10 years ago

I already implemented it long time ago on this GitHub recommendations website: http://www.yasiv.com/github/#/

But it is not done in a modular way. I would love it to be a simple npm module, which could be installed as angular directive. Something like:

> npm install githuboauth

And then:

 <githuboauth></githuboauth>
josdejong commented 10 years ago

Idea for a totally different solution: instead of a pure client side solution which fetches all data directly via the github API, create a simple backend, a node.js web app on Heroku or something like that, to cache the data and update every 5 minutes or so. The client then only has to display a sortable/filterable table.

(if you want to go totally crazy you can add a backend database (couchdb or mongodb) to store all data over time, so you can even display graphs and go wild with statistics)

anvaka commented 10 years ago

I like it!

anvaka commented 10 years ago

Implemented heroku app: source, endpoint

@josdejong you were right in the very beginning. Code now looks much simpler than it used to be with oauth.

josdejong commented 10 years ago

ah, nice and simple :).

A "loading..." message on the endpoint may be useful for when the heroku app has a cold start.

anvaka commented 10 years ago

Thank you! This makes senses, added.