anvc / scalar

Born-digital, open source, media-rich scholarly publishing that’s as easy as blogging.
Other
231 stars 73 forks source link

IIIf integration #139

Closed dodget closed 4 years ago

dodget commented 4 years ago

This PR integrates mirador3 and IIIF functionality to scalar by:

The branch for this PR is based off of scalar v2.5.12. I'd be happy to update it with the latest changes from master if requested.

eloyer commented 4 years ago

@dodget Fantastic to see this up and running — thanks so much. Wondering if you might have any insight into why IIIF instances at small, medium, and large sizes are exceeding the vertical bounds of their container and overlapping the .mediaElementFooter element below? It's especially notable when you roll over the media; the whole instance expands vertically, when normally we'd expect the instance to remain fixed and the footer to expand.

dodget commented 4 years ago

Hm, that's not something that I observed, but I'll do some investigating and see if I can issue a fix. Thanks for the heads up @eloyer

dodget commented 4 years ago

It looks like I am going to have to set find a way to inherit a max-height on #mirador-viewer. I'll do my best to come up with a clean solution.

eloyer commented 4 years ago

@dodget Would you mind taking a look at an issue we've seen where two IIIF instances on a page will sometimes fail to load? Here's an example. The issue is intermittent, but if it doesn't happen the first time it'll usually occur after one or two reloads.

dodget commented 4 years ago

Sure thing, I'll take a look when I get a chance.

dodget commented 4 years ago

Heads up @eloyer - I should have a fix coming for this early next week

eloyer commented 4 years ago

Excellent, thanks for the update @dodget !