Mirador viewer max-height

anvc / scalar

Born-digital, open source, media-rich scholarly publishing that’s as easy as blogging.

Other

231 stars 73 forks source link

Closed dodget closed 4 years ago

dodget commented 4 years ago

This PR resolves the issue of Mirador overflowing its mediaElement bounds by:

Setting the max-height of .mirador-viewer to the max-height of .mediaContainer

I tested it locally, and it should resolve the issues you pointed out @eloyer

Thanks for pointing it out. I don't know scalar well enough to have noticed the problem :/

eloyer commented 4 years ago

@dodget Looks great, thanks. This is a minor detail; overall the integration was very expertly done and much appreciated, great work.