anvc / scalar

Born-digital, open source, media-rich scholarly publishing that’s as easy as blogging.
Other
231 stars 73 forks source link

Mirador integration not functioning #180

Closed waltster closed 2 years ago

waltster commented 2 years ago

I have been testing a Scalar instance and trying to use the Mirador viewer with a manifest. When I load it into the included viewer, it does not render the manifest content. To remedy the issue, I built my own Mirador.min.js and uploaded it to the Scalar instance and was able to get it working. I am wondering if this has been reported before? If so, is there a known fix?

The manifest is valid IIIF v3.

Included build of Mirador: Screen Shot 2021-10-30 at 12 50 43 PM

My build of Mirador: Screen Shot 2021-10-30 at 12 52 11 PM

eloyer commented 2 years ago

We haven't encountered this before — would you be willing to share your manifest for us to test with?

waltster commented 2 years ago

@eloyer sure, here it is!

{
  "@context": "http://iiif.io/api/presentation/3/context.json",
  "id": "https://piranesi-test.reclaim.hosting/walts-test-book/media/Manifest_TomJerryV2.json",
  "type": "Manifest",
  "label": {
    "en": [
      "Tom and Jerry doing the whole like fighting thing."
    ]
  },
  "items": [
    {
      "id": "https://piranesi-test.reclaim.hosting/walts-test-book/media/testmanifest/canvas/p1",
      "type": "Canvas",
      "height": 3024,
      "width": 4032,
      "items": [
        {
          "id": "https://piranesi-test.reclaim.hosting/walts-test-book/media/testmanifest/page/p1/1",
          "type": "AnnotationPage",
          "items": [
            {
              "@context": [
                "http://www.w3.org/ns/anno.jsonld",
                "http://iiif.io/api/presentation/3/context.json"
              ],
              "id": "https://piranesi-test.reclaim.hosting/walts-test-book/media/testmanifest/annotation/p0001-image",
              "type": "Annotation",
              "motivation": "painting",
              "body": {
                "id": "https://env-4072537.us.reclaim.cloud/iiif/2/tomjerry.jpeg/full/full/0/default.jpg",
                "type": "Image",
                "format": "image/jpeg",
                "height": 168,
                "width": 300
              },
              "target": "https://piranesi-test.reclaim.hosting/walts-test-book/media/testmanifest/canvas/p1"
            }
          ]
        }
      ]
    }
  ]
}
eloyer commented 2 years ago

@dodget Would you mind taking a look at this? I can confirm the reported behavior. Perhaps the bundled player is due for an update?

dodget commented 2 years ago

@eloyer - I'll take a look and hopefully get it resolved by the end of the week!

craigdietrich commented 2 years ago

@eloyer @dodget

Does @waltster's JSON load into the Mirador demo at https://mirador-dev.netlify.app/__tests__/integration/mirador/ ?

waltster commented 2 years ago

@craigdietrich @eloyer @dodget The JSON does load, here's a Gist with it that you can use to test.

eloyer commented 2 years ago

Thanks so much @dodget !