anvc / scalar

Born-digital, open source, media-rich scholarly publishing that’s as easy as blogging.
Other
231 stars 73 forks source link

Issue/62 #66

Closed crism closed 4 years ago

crism commented 7 years ago

This adds support for Omeka S import (#62). Could be generalized to other JSON-LD sources if desired. Includes #65, which fixes #63, as a prerequisite.

craigdietrich commented 7 years ago

Fantastic, thanks! I'll merge this up soon.

crism commented 7 years ago

@craigdietrich, this is the PR for #62, which also fixes #64. It includes the changes for #63 (PR #65).

alexdryden commented 4 years ago

Hi @craigdietrich, I was just following up on this pull request after testing this feature with the the most recent versions of Omeka-S and Scalar. I'm in the role @crism was in when this feature was developed.

craigdietrich commented 4 years ago

@alexdryden Hi! So, this pull request is ready to go? No testing or integration needed on our end?

Thanks!

alexdryden commented 4 years ago

Yeah, good to go @craigdietrich! We've used it with Omeka-S API 1.x and (the current) 2.x, and I just tested with Scalar v2.5.12 and it works as expected.

Thanks!

craigdietrich commented 4 years ago

All set!