search

anvc / scalar

Born-digital, open source, media-rich scholarly publishing that’s as easy as blogging.
Other
231 stars 73 forks source link

anvc/scalar#72: quote database name #73

Closed crism closed 7 years ago

crism commented 7 years ago

Fixes #72. Tested on our hyphen-having sandbox.

craigdietrich commented 7 years ago

Whoa, this is great, thanks!

The one hiccup is that ARC2 is an external library https://github.com/semsol/arc2, but I've contributed to their repository before. So I'm thinking you do a pull request with this there, then I go ahead and update ARC2 on Scalar (it's probably a good time to do that in any event). What do you think @crism?

crism commented 7 years ago

I filed it as semsol/arc2#94 as well, after I’d already created this PR.

craigdietrich commented 7 years ago

Ah, okay! Did they merge the pull request there? If not (like, if it'll take a while there) I'll go ahead and merge this at Scalar and we can worry about syncing things up later.

k00ni commented 7 years ago

Because i missed your discussion here, i "accidentally" ported the mentioned fix and add a basic test for ARC2_Store myself (https://github.com/semsol/arc2/pull/96). I hope it fully covers your case. :)

crism commented 7 years ago

Fantastic, @k00ni, thanks!

craigdietrich commented 7 years ago

Awesome. thanks @k00ni ! So, just to confirm, the Merge over on the arc2 repository includes the fix made here, which is adding MySQL quotes around the database name?

craigdietrich commented 7 years ago

Oh, I see ... over at arc2 they've Merged one but not the other, the other being the quotes DB name fix.

k00ni commented 6 years ago

Oh, I see ... over at arc2 they've Merged one but not the other, the other being the quotes DB name fix.

I thought i added the quote-DB-name-fix to my pull request.

https://github.com/semsol/arc2/commit/9db40c0a35dfb7b6feacb2b3d66e2c920bc2fca6#diff-3ad57ff8fd810858d6ad00eef07f4a91

What do you mean @craigdietrich?