Solved deprecations of 0.8.x & Implicit compatibility bugs

anvil-vtt / FateX

FateX is the extended Fate game system for FoundryVTT.

MIT License

22 stars 16 forks source link

Solved deprecations of 0.8.x & Implicit compatibility bugs #60

Closed saif-ellafi closed 3 years ago

saif-ellafi commented 3 years ago

Fixed deprecations in 0.8.x Added explicit ts-ignore until types are available for 0.8.x

Implicit bugfixes addressed:

Creating/deleting skills was throwing errors
Sorting by Rank needs a manual rendering since document update does no longer trigger that in 0.8
Adding aspects (although there is still a missing update somewhere, causing aspect labels to cleanup themselves)

Pjb518 commented 3 years ago

Looks like you beat me to this by a few minutes haha! #61

PatrickBauer commented 3 years ago

@saif-ellafi Thank you very much! 😁 Is "isOwner" available in Foundry 0.7? I can't check it myself right now but will take a closer look at your changes later today 👍 Right now I'm trying to support 0.7 and 0.8 at the same time and I think that might be possible without to much hassle.

saif-ellafi commented 3 years ago

@saif-ellafi Thank you very much! 😁 Is "isOwner" available in Foundry 0.7? I can't check it myself right now but will take a closer look at your changes later today 👍 Right now I'm trying to support 0.7 and 0.8 at the same time and I think that might be possible without to much hassle.

Unfortunately not all of them are available, there are breaking changes in item creation also, and some bugs all around template and sheet customization. I think yes, you will have trouble supporting both simultaneously.

saif-ellafi commented 3 years ago

In my opinion, if there are no new features on one on another, there is no much benefit in supporting simultaneous versions! You can have each people on their own branch, and in the worst case cherry pick actual new features. But that is just my opinion :) Overall depends on the amount of time and effort on doing dual testing and compatibility tests all around.

saif-ellafi commented 3 years ago

With latest commit a fixed actual errors of item management that were directly not working on 0.8.x You can reproduce various of the broken functionalities by creating and deleting items outside this branch.

saif-ellafi commented 3 years ago

This branch now indirectly fixes bugs and issues with 0.8.x. Updating the Title