search

anvil-vtt / FateX

FateX is the extended Fate game system for FoundryVTT.
MIT License
22 stars 16 forks source link

Fixes for deprecated properties and methods in 0.8.x #61

Closed Pjb518 closed 3 years ago

Pjb518 commented 3 years ago

I've updated several deprecated properties and methods that were triggering warnings in Foundry 0.8.x. There are still some deprecation warnings that I may get to later on, including several warnings when creating new items on sheets.

I've had to disable typing on line 106 of SkillItem.ts, as the League types are not up to date. I'm planning to submit a PR for their repo as well, but it could be a little while before that gets released.

PatrickBauer commented 3 years ago

Hey @Pjb518 thank you very much for your contribution. Lots of these changes are great but I've got a question about things like sheet.entity => sheet.document. This would prevent people to use this new version in 0.7, wouldn't it? I've tried to support both versions at the same time right now and I'm okay if not everything is up to date with the new API as long as we don't break BC.

Pjb518 commented 3 years ago

I believe almost all of the changes are going to prevent the system from working in 0.7.x. Everything here is going to be required for 0.9.x compatibility, but they're only recommended for 0.8.x.

Let me just take a look at some of the release notes, because it may be the case that some of these changes have been backported to the new 0.7.10 release for the sake of compatibility.

PatrickBauer commented 3 years ago

Sounds good. At least the changes to items.get should work and will be added in any case. I'm gonna try to include your PR later today and will check again for compatability issues in 0.7 👍

Pjb518 commented 3 years ago

I think we should close this PR in favour of @saif-ellafi's (#60) which is now more extensive. Their version is currently missing some of the items.get fixes included here, however.

saif-ellafi commented 3 years ago

I think we should close this PR in favour of @saif-ellafi's (#60) which is now more extensive. Their version is currently missing some of the items.get fixes included here, however.

Sounds good! Sorry that we duplicated a bit of work :) I can merge this branch changes to make sure nothing goes missing.

saif-ellafi commented 3 years ago

Done, all differences now included in #60