Closed Pjb518 closed 3 years ago
Oh yes! I had suffered this too! awesome
It's a bit hard to define which one is the correct way, what do other systems do? fit to size?
It's a bit hard to define which one is the correct way, what do other systems do? fit to size?
There definitely is always going to be a problem, and I don't think there's a unified solution across systems. I know that some maintain the image aspect ratio and then set the image height to the container height, but that comes with its own problems.
I think the solution I've proposed here is going to be right more of the time than the centred version, but the best solution would be to have the user select a "hotpot" for their image when setting an actor image. That way we can determine the important parts of the image and ensure that they're always visible. Obviously a lot more work than just making a best guess like we're doing here though.
Another alternative might be to prompt users to crop their image when setting an actor image when the aspect ratio doesn't match the allotted space on the sheet. We can then quite easily shift the image by an appropriate amount to match the user's settings.
I think this solution is good enough for now, thanks for contributing!
Very small update taking care of issue #52. Instead of centring the images within the allotted space on the character sheet, we now ensure that the top of the image is always visible. This should help to ensure that character heads are not being cut off.
Instead of this:
We get this: