anvil-vtt / FateX

FateX is the extended Fate game system for FoundryVTT.
MIT License
23 stars 16 forks source link

Code cleanup #66

Closed Pjb518 closed 3 years ago

Pjb518 commented 3 years ago

This PR is mostly focused on standardising the naming convention used for CSS classes and simplifying the styling and templates throughout the system.

While the update is focused on the CSS and HTML, some changes will necessarily be made to the JS implementation wherever classes have been used as selectors.

Note: Since the new message cards have significant template changes, older messages will not be correctly styled. It doesn't have any meaningful impact on the end user other than the fact that they'll have some ugly messages in their chat history. It might be worth notifying users when they open the updated system for the first time, just so we don't get a pile of erroneous bug reports.

Note: We've instead decided to ship legacy chat message styles so that users don't end up with random unstyled messages in their chat history.

Pjb518 commented 3 years ago

TODO: The sheet setup header was broken when the main sheet header was rewritten. Will probably tackle this this afternoon.

Finished

Pjb518 commented 3 years ago

TODO

Finished

Pjb518 commented 3 years ago

TODO

image

image

It should look for like this:

image

Finished

PatrickBauer commented 3 years ago

Great work once again, thank you very much! ❤️