anvil-vtt / FateX

FateX is the extended Fate game system for FoundryVTT.
MIT License
22 stars 16 forks source link

Additional style updates #74

Closed Pjb518 closed 3 years ago

Pjb518 commented 3 years ago

A third round of style updates to standardise the naming system, remove old style declarations, and simplify the overall implementation.

Update 1: The latest round of changes should complete the update to the new naming scheme, following standard BEM conventions with a handful of utility classes.

The only classes which have not been updated are those for the forthcoming actor groups feature. It's likely that only a handful of new styles will be needed over the current generic components, meaning that most of the existing front-end code for this feature will be discarded.

Update 2: The PR now includes updates for the majority of the actor group styles, as well as template changes for the actor group feature.

Update 3: The PR now also includes the preliminary work for setting custom themes. The var function is used to associate custom property names with specific system elements; however, no values for these custom properties is set. Instead, a fallback value is provided for each var, acting as the system default. Users can modify the styles by setting values for the custom property names used in the system CSS.

These additions will be built upon when we get around to implementing custom styling for the system interface.

Pjb518 commented 3 years ago

Known issues as of the latest commit: