Attempting to address Issue #376 - Githubissues

anvilco / node-anvil

Node API Client for Anvil

https://www.useanvil.com/developers/

17 stars 6 forks source link

Attempting to address Issue #376 #413

Closed wi-ski closed 9 months ago

wi-ski commented 9 months ago

Description of the change

See this outline: https://github.com/anvilco/node-anvil/issues/376#issuecomment-1845635584 and this loom: https://www.loom.com/share/f2f0bd7734e74ed3a7fa6e8f9a37e990?sid=971442dd-615b-444b-8e9b-b5d3c26c11ee

Type of change

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

https://github.com/anvilco/node-anvil/issues/376#issuecomment-1845635584

Checklists

Development

[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development
[ ] No previous tests unrelated to the changed code fail in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
[ ] At least one reviewer has been requested
[ ] Changes have been reviewed by at least one other engineer
[ ] The relevant project board has been selected in Projects to auto-link to this pull request

newhouse commented 9 months ago

Closed in favor of https://github.com/anvilco/node-anvil/pull/414

But thank you!