anvilco / node-anvil

Node API Client for Anvil
https://www.useanvil.com/developers/
17 stars 6 forks source link

Bug Fix - Eliminate deprecated response.buffer() invocation #442

Closed wi-ski closed 7 months ago

wi-ski commented 7 months ago

Description of the change

These changes introduce:

  1. Removal of the response.buffer() invocation (Deprecated)
  2. Introduction of response.arrayBuffer()

This callsite is triggering noise in our error alerts, looks like:

(node:148) [node-fetch#buffer] DeprecationWarning: Please use 'response.arrayBuffer()' instead of 'response.buffer()'
(Use `node --trace-deprecation ...` to show where the warning was created)

Related node fetch issue: https://github.com/node-fetch/node-fetch/issues/1401

Type of change

Related issues

Fixes

Checklists

Development

Code review

newhouse commented 7 months ago

@wi-ski going to take a slightly different approach to a solution that ensures backwards compatibility, but thank you and I will get this out ASAP!

newhouse commented 7 months ago

Closing in favor of https://github.com/anvilco/node-anvil/pull/443

newhouse commented 7 months ago

Fixed in v 3.3.0