fix: cant remove handlers after wrapping in augment

[s-cork]

close #490

shouldn't need a change log since this is unreleased does the fast thing if we're don't need to wrap an event handler for augment keeps a cache of augmented handlers so that removing handlers works

[s-cork]

Current dependencies on/for this PR:

• main
  • PR #492 👈

This stack of pull requests is managed by Graphite.

[s-cork]

i think this is probably ok, but do we want to implement a maxsize lru_cache instead? i can easily see that the cache could get quite large if augment handlers are being used in a datagrid row template

[rhurlbatt]

For what it's worth, we do use augment in data rows to hide and show action buttons dynamically so anything to optimise that would be greatly appreciated.

On Wed, 29 Nov 2023, 9:33 am stu, @.***> wrote:

i think this is probably ok, but do we want to implement a maxsize lru_cache instead? i can easily see that the cache could get quite large if augment handlers are being used in a datagrid row template

— Reply to this email directly, view it on GitHub https://github.com/anvilistas/anvil-extras/pull/492#issuecomment-1831050719, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHTGL6CVZ6NIOGEM4MIA7RTYG2GGNAVCNFSM6AAAAAA76VJFV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZRGA2TANZRHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[s-cork]

Noted.

If you're really looking to optimise you might want to consider attaching event listeners directly to dom nodes with anvil.js.get_dom_node.

Augment is really for convenience these days since it was written before anvil.js existed.